Sovran_Systems/Sovran_SystemsOS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #257 from naturallaw777/copilot/optimize-dns-resolution-delay

Browse Source 
Remove blocking DNS checks from `/api/services` by making domain health cache-only
This commit is contained in:
Sovran_Systems
2026-04-15 13:37:15 -05:00
committed by GitHub
parent 0b76a257ce 31c7b796f8
commit 1e2b11b235
1 changed files with 2 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
app/sovran_systemsos_web/server.py
View File

@@ -2409,17 +2409,7 @@ async def api_services():
if ps == "closed": if ps == "closed":
has_port_issues = True has_port_issues = True
break break
has_domain_issues = False has_domain_issues = bool(needs_domain and domain and cached_reachable is False)
if needs_domain:
has_domain_issues = await loop.run_in_executor(
None,
_check_domain_health_fast,
domain,
_cached_external_ip,
)
if not has_domain_issues and domain:
if cached_reachable is False:
has_domain_issues = True
if has_port_issues or has_domain_issues: if has_port_issues or has_domain_issues:
health = "needs_attention" health = "needs_attention"
else: else:
@@ -2440,17 +2430,7 @@ async def api_services():
# For enabled services that are inactive (e.g. socket-activated PHP-FPM), # For enabled services that are inactive (e.g. socket-activated PHP-FPM),
# still check domain/port health so status remains consistent with # still check domain/port health so status remains consistent with
# other domain services when there are actionable issues. # other domain services when there are actionable issues.
has_domain_issues = False has_domain_issues = bool(needs_domain and domain and cached_reachable is False)
if needs_domain:
has_domain_issues = await loop.run_in_executor(
None,
_check_domain_health_fast,
domain,
_cached_external_ip,
)
if not has_domain_issues and domain:
if cached_reachable is False:
has_domain_issues = True
has_port_issues = False has_port_issues = False
if port_requirements: if port_requirements:
for p in port_requirements: for p in port_requirements: