Fix stale update state causing false Update complete when no updates available

Agent-Logs-Url: https://github.com/naturallaw777/staging_alpha/sessions/1cc7ff30-4a1b-46f7-a20a-2ec0cbdfe291

Co-authored-by: naturallaw777 <99053422+naturallaw777@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2026-04-12 04:29:11 +00:00
committed by GitHub
parent 6e5863ed48
commit 31f1e16a3c
2 changed files with 15 additions and 0 deletions

View File

@@ -2371,12 +2371,26 @@ async def api_updates_run():
"""Kick off the detached update systemd unit."""
loop = asyncio.get_event_loop()
# Recover any stale RUNNING state before checking, so a leftover status
# file from a previous (now-inactive) update unit doesn't cause a false
# already_running response that sends the frontend into a stale-log poll.
await loop.run_in_executor(
None, _recover_stale_status, UPDATE_STATUS, UPDATE_LOG, UPDATE_UNIT
)
status = await loop.run_in_executor(None, _read_update_status)
if status == "RUNNING":
return {"ok": True, "status": "already_running"}
available = await loop.run_in_executor(None, check_for_updates)
if not available:
# Clear stale status/log so they don't contaminate future modal opens.
_write_update_status("IDLE")
try:
with open(UPDATE_LOG, "w") as f:
f.write("")
except OSError:
pass
return {"ok": True, "status": "no_updates"}
# Clear stale status and log BEFORE starting the unit