Merge pull request #15 from naturallaw777/copilot/fix-user-existence-check

[WIP] Fix user registration error on existing machines

modules/synapse.nix

@@ -153,7 +153,7 @@ EOF
     };
     path = [ pkgs.pwgen pkgs.matrix-synapse pkgs.curl pkgs.coreutils pkgs.jq ];
     script = ''
-      set -euo pipefail
+      set -uo pipefail
 
       # Wait for Synapse to be fully responsive
       for i in {1..30}; do
@@ -177,15 +177,25 @@ EOF
         TEST_USER="test"
         TEST_PASS=$(pwgen -s 24 1)
 
-        # Create Admin user
+        ADMIN_CREATED=true
-        register_new_matrix_user -c /run/matrix-synapse/runtime-config.yaml \
+        TEST_CREATED=true
-          -u "$ADMIN_USER" -p "$ADMIN_PASS" -a http://localhost:8008
 
-        # Create Test user (non-admin)
+        # Create Admin user (tolerate "already exists")
-        register_new_matrix_user -c /run/matrix-synapse/runtime-config.yaml \
+        if ! register_new_matrix_user -c /run/matrix-synapse/runtime-config.yaml \
-          -u "$TEST_USER" -p "$TEST_PASS" --no-admin http://localhost:8008
+          -u "$ADMIN_USER" -p "$ADMIN_PASS" -a http://localhost:8008 2>&1; then
+          echo "Admin user already exists, skipping."
+          ADMIN_CREATED=false
+        fi
 
-        # Save the credentials
+        # Create Test user (tolerate "already exists")
+        if ! register_new_matrix_user -c /run/matrix-synapse/runtime-config.yaml \
+          -u "$TEST_USER" -p "$TEST_PASS" --no-admin http://localhost:8008 2>&1; then
+          echo "Test user already exists, skipping."
+          TEST_CREATED=false
+        fi
+
+        # Write credentials file
+        if [ "$ADMIN_CREATED" = true ] && [ "$TEST_CREATED" = true ]; then
           cat > "$CREDS_FILE" << CREDS
 Matrix (Element) Credentials
 ════════════════════════════
@@ -199,9 +209,24 @@ Password: $ADMIN_PASS
 Username: @$TEST_USER:$DOMAIN
 Password: $TEST_PASS
 CREDS
+        else
+          cat > "$CREDS_FILE" << CREDS
+Matrix (Element) Credentials
+════════════════════════════
+Homeserver URL: https://$DOMAIN
+
+[ Admin Account ]
+Username: @$ADMIN_USER:$DOMAIN
+Password: $(if [ "$ADMIN_CREATED" = true ]; then echo "$ADMIN_PASS"; else echo "(pre-existing — password set during original setup)"; fi)
+
+[ Test Account ]
+Username: @$TEST_USER:$DOMAIN
+Password: $(if [ "$TEST_CREATED" = true ]; then echo "$TEST_PASS"; else echo "(pre-existing — password set during original setup)"; fi)
+CREDS
+        fi
 
         chmod 600 "$CREDS_FILE"
-        echo "Matrix users created successfully."
+        echo "Matrix users setup completed."
       fi
     '';
   };