From 7a0a43dfd3ad32055cfabfeee8f33fa5104fd5dd Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Wed, 15 Apr 2026 18:19:49 +0000
Subject: [PATCH] Add server_id guard and AppAPI rationale

Agent-Logs-Url: https://github.com/naturallaw777/staging_alpha/sessions/e94844f0-187d-4b52-9302-7e61d3e5804a

Co-authored-by: naturallaw777 <99053422+naturallaw777@users.noreply.github.com>
---
 modules/nextcloud.nix | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/modules/nextcloud.nix b/modules/nextcloud.nix
index 9384708..d28c09d 100755
--- a/modules/nextcloud.nix
+++ b/modules/nextcloud.nix
@@ -82,6 +82,10 @@ lib.mkIf config.sovran_systemsOS.services.nextcloud {
       ADMIN_USER=$(pwgen -s 16 1)
       ADMIN_PASS=$(pwgen -s 24 1)
       SERVER_ID=$(head -c 16 /dev/urandom | od -An -tx1 | tr -d ' \n')
+      if [ -z "$SERVER_ID" ]; then
+          echo "Failed to generate Nextcloud server_id"
+          exit 1
+      fi
 
       echo "══════════════════════════════════════════════"
       echo "  Nextcloud Automated Installation"
@@ -158,6 +162,7 @@ lib.mkIf config.sovran_systemsOS.services.nextcloud {
         php $INSTALL_DIR/occ db:add-missing-columns
         php $INSTALL_DIR/occ db:add-missing-primary-keys
         php $INSTALL_DIR/occ maintenance:repair --include-expensive
+        # AppAPI deploy daemon warnings are avoided by disabling app_api when present.
         if php $INSTALL_DIR/occ app:info app_api >/dev/null 2>&1; then
           php $INSTALL_DIR/occ app:disable app_api
         fi