Sovran_Systems/Sovran_SystemsOS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: remove _recover_stale_status() from api_updates_run, verify unit active before trusting RUNNING status

Browse Source 
Agent-Logs-Url: https://github.com/naturallaw777/staging_alpha/sessions/3a855cab-5d0d-4c32-984c-5c88d922934e

Co-authored-by: naturallaw777 <99053422+naturallaw777@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2026-04-12 05:00:03 +00:00
committed by GitHub
parent e1a06079fd
commit 90d423e94b
1 changed files with 15 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
app/sovran_systemsos_web/server.py
View File

@@ -2371,16 +2371,23 @@ async def api_updates_run():
"""Kick off the detached update systemd unit.""" """Kick off the detached update systemd unit."""
loop = asyncio.get_event_loop() loop = asyncio.get_event_loop()
# Recover any stale RUNNING state before checking, so a leftover status # Check if the update unit is genuinely running (not just a stale file).
# file from a previous (now-inactive) update unit doesn't cause a false # Do NOT call _recover_stale_status() here — it appends to the log file
# already_running response that sends the frontend into a stale-log poll. # which causes stale log content to appear in the frontend modal.
await loop.run_in_executor(
None, _recover_stale_status, UPDATE_STATUS, UPDATE_LOG, UPDATE_UNIT
)
status = await loop.run_in_executor(None, _read_update_status) status = await loop.run_in_executor(None, _read_update_status)
if status == "RUNNING": if status == "RUNNING":
unit_active = await loop.run_in_executor(
None, lambda: sysctl.is_active(UPDATE_UNIT, "system")
)
if unit_active == "active":
return {"ok": True, "status": "already_running"} return {"ok": True, "status": "already_running"}
# Stale RUNNING — clear it and fall through to the normal flow.
_write_update_status("IDLE")
try:
with open(UPDATE_LOG, "w") as f:
f.write("")
except OSError:
pass
available = await loop.run_in_executor(None, check_for_updates) available = await loop.run_in_executor(None, check_for_updates)
if not available: if not available: