From c2f3f048b98a8ee5a41313781bda0d7c42ca63e4 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 24 Jun 2026 22:19:14 +0000 Subject: [PATCH] fix: simplify internal IP copy handling --- app/sovran_systemsos_web/static/js/service-detail.js | 3 ++- app/sovran_systemsos_web/static/onboarding.js | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/app/sovran_systemsos_web/static/js/service-detail.js b/app/sovran_systemsos_web/static/js/service-detail.js index 627f9a4..036e90f 100644 --- a/app/sovran_systemsos_web/static/js/service-detail.js +++ b/app/sovran_systemsos_web/static/js/service-detail.js @@ -154,7 +154,8 @@ async function openServiceDetailModal(unit, name, icon) { ''; if (unit === "livekit.service" && data.extra_ports && data.extra_ports.length > 0) { - var internalIp = (data.internal_ip && String(data.internal_ip).trim()) ? String(data.internal_ip).trim() : ""; + var trimmedInternalIp = data.internal_ip ? String(data.internal_ip).trim() : ""; + var internalIp = trimmedInternalIp || ""; var internalIpHtml = internalIp ? escHtml(internalIp) : "Could not detect"; var routerIpHelp = internalIp ? "Use this IP address as the destination/internal IP when creating each router forwarding rule." diff --git a/app/sovran_systemsos_web/static/onboarding.js b/app/sovran_systemsos_web/static/onboarding.js index b703b4d..f6b5868 100644 --- a/app/sovran_systemsos_web/static/onboarding.js +++ b/app/sovran_systemsos_web/static/onboarding.js @@ -527,7 +527,8 @@ async function loadStep4() { return; } - var internalIp = (networkData && networkData.internal_ip && String(networkData.internal_ip).trim()) ? String(networkData.internal_ip).trim() : ""; + var trimmedInternalIp = (networkData && networkData.internal_ip) ? String(networkData.internal_ip).trim() : ""; + var internalIp = trimmedInternalIp || ""; var hasInternalIp = !!internalIp; var ip = escHtml(internalIp || "Could not detect"); var routerIpHelp = hasInternalIp