From e43552373cd92a3125b9cf65d54f6ae4168d07b8 Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Thu, 2 Apr 2026 23:27:14 +0000
Subject: [PATCH] fix: validate domain_name to prevent path injection; fix
 toggle revert logic

Agent-Logs-Url: https://github.com/naturallaw777/staging_alpha/sessions/9088415a-efc3-4dd1-9c22-877a543af47b

Co-authored-by: naturallaw777 <99053422+naturallaw777@users.noreply.github.com>
---
 app/sovran_systemsos_web/server.py     | 10 ++++++++++
 app/sovran_systemsos_web/static/app.js |  4 ++--
 2 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/app/sovran_systemsos_web/server.py b/app/sovran_systemsos_web/server.py
index f4de31c..5fbd526 100644
--- a/app/sovran_systemsos_web/server.py
+++ b/app/sovran_systemsos_web/server.py
@@ -929,9 +929,19 @@ class DomainSetRequest(BaseModel):
     ddns_url: str = ""
 
 
+_SAFE_NAME_RE = re.compile(r'^[a-zA-Z0-9_-]+$')
+
+
+def _validate_safe_name(name: str) -> bool:
+    """Return True if name contains only safe path characters (no separators)."""
+    return bool(name) and _SAFE_NAME_RE.match(name) is not None
+
+
 @app.post("/api/domains/set")
 async def api_domains_set(req: DomainSetRequest):
     """Save a domain and optionally register a DDNS URL."""
+    if not _validate_safe_name(req.domain_name):
+        raise HTTPException(status_code=400, detail="Invalid domain_name")
     os.makedirs(DOMAINS_DIR, exist_ok=True)
     domain_path = os.path.join(DOMAINS_DIR, req.domain_name)
     with open(domain_path, "w") as f:
diff --git a/app/sovran_systemsos_web/static/app.js b/app/sovran_systemsos_web/static/app.js
index 179c0ed..39f875f 100644
--- a/app/sovran_systemsos_web/static/app.js
+++ b/app/sovran_systemsos_web/static/app.js
@@ -930,9 +930,9 @@ function buildFeatureCard(feat) {
   var toggleLabel = card.querySelector(".feature-toggle");
   toggle.addEventListener("change", function() {
     var newEnabled = toggle.checked;
-    // Revert visually until confirmed
+    // Revert visually to original state while confirmation/modal is pending
     toggle.checked = feat.enabled;
-    if (newEnabled) { toggleLabel.classList.remove("active"); } else { toggleLabel.classList.add("active"); }
+    if (feat.enabled) { toggleLabel.classList.add("active"); } else { toggleLabel.classList.remove("active"); }
     handleFeatureToggle(feat, newEnabled);
   });